don't leak all toplevel windows on other screens (correctly remove all

2005-11-23  Michael Natterer  <mitch@imendio.com>

	* gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
	windows on other screens (correctly remove all temporary
	references).

diff --git a/ChangeLog b/ChangeLog
index cd8f5c72e01f14af90bef2056395fd87128cf1d0..3935903c019628ec5f40174da9b166508ac10777 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2005-11-23  Michael Natterer  <mitch@imendio.com>
+
+       * gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
+       windows on other screens (correctly remove all temporary
+       references).
+
 2005-11-23  Michael Natterer  <mitch@imendio.com>
 
        Added symbolic themable colors. Patch is a merged version of

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index cd8f5c72e01f14af90bef2056395fd87128cf1d0..3935903c019628ec5f40174da9b166508ac10777 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,9 @@
+2005-11-23  Michael Natterer  <mitch@imendio.com>
+
+       * gtk/gtkrc.c (gtk_rc_reset_widgets): don't leak all toplevel
+       windows on other screens (correctly remove all temporary
+       references).
+
 2005-11-23  Michael Natterer  <mitch@imendio.com>
 
        Added symbolic themable colors. Patch is a merged version of

diff --git a/gtk/gtkrc.c b/gtk/gtkrc.c
index 41c8160d1bd8dc7a2dbabd5ca8ab5d8b5847a92a..33396bb6df50a6277fab834b0147ecacf3abf558 100644 (file)
--- a/gtk/gtkrc.c
+++ b/gtk/gtkrc.c
@@ -1400,8 +1400,9 @@ gtk_rc_reset_widgets (GtkSettings *settings)
       if (gtk_widget_get_screen (list->data) == settings->screen)
        {
          gtk_widget_reset_rc_styles (list->data);
-         g_object_unref (list->data);
        }
+
+      g_object_unref (list->data);
     }
   g_list_free (toplevels);
 }